Repository navigation
docs(otel-genai): include required --enforcement-mode in usage example - #279
Merged
Merged
Conversation
The Usage example in `otel_to_trace.py` omits `--enforcement-mode`, while the CLI now requires that argument with no default. Copying the example as written therefore fails with an argparse error. This adds the same explicit value already shown in the otel-genai README: `--enforcement-mode declared` This follows the required-argument shape adopted in the agentrust-io/trace-spec#416 follow-up: callers state the actual mode rather than the adapter inferring one. Docstring only; no behavior change.
solloek369-arch
requested review from
a team,
carloshvp and
imran-siddique
as code owners
October 4, 2026 15:42
imran-siddique
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Usage example in
otel_to_trace.pyomits--enforcement-mode, while the CLI now requires that argument with no default. Copying the example as written therefore fails with an argparse error.This adds the same explicit value already shown in the otel-genai README:
--enforcement-mode declaredThis follows the required-argument shape adopted in the agentrust-io/trace-spec#416 follow-up: callers state the actual mode rather than the adapter inferring one. Docstring only; no behavior change.